Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Some npm config commands no longer work #906

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 24, 2023

Description

% npm --version

9.8.0

% npm config set python python3

npm ERR! `python` is not a valid npm option

% npm config set msvs_version 2022

npm ERR! `msvs_version` is not a valid npm option

Motivation and Context

issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

Copy link
Contributor

@robertleeplummerjr robertleeplummerjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertleeplummerjr robertleeplummerjr merged commit 9808bde into BrainJS:master Dec 6, 2023
0 of 9 checks passed
@cclauss cclauss deleted the patch-2 branch December 6, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants